Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deadcode #8950

Merged
merged 4 commits into from
Mar 21, 2017
Merged

Remove deadcode #8950

merged 4 commits into from
Mar 21, 2017

Conversation

jipjop
Copy link
Contributor

@jipjop jipjop commented Mar 20, 2017

Description

Removed unused dependencies from several classes. Got the warnings from the PHP CS Fixer.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

Such kind of PR is useless as we can remove such occurrences all over the code automatically. 3fc476b looks like you do it manually.

The crux is that we don't enforce that no such new code appear currently. I believe we shall implement static test enforcing php-cs-fixer rules first and then do automatic fix of the whole codebase only once at a suitable moment.

@ishakhsuvarov
Copy link
Contributor

@orlangur I totally agree, that we should remove automatically and enforce with the test, however:
While such occurrences exist there is no harm removing those in any possible way.

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 21, 2017
@ishakhsuvarov ishakhsuvarov added this to the March 2017 milestone Mar 21, 2017
@magento-team magento-team merged commit 3fc476b into magento:develop Mar 21, 2017
magento-team pushed a commit that referenced this pull request Mar 21, 2017
@vrann
Copy link
Contributor

vrann commented Mar 21, 2017

@jipjop Thank you for the contribution!

@orlangur
Copy link
Contributor

@ishakhsuvarov I was mostly scared by manual nature of these changes :) It's ok to run unused_use fixer fully or partially but not safe to do same changes manually. Hope we have enough automation for changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants